Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening some files hangs helix #2187

Closed
CptPotato opened this issue Apr 20, 2022 · 6 comments
Closed

Opening some files hangs helix #2187

CptPotato opened this issue Apr 20, 2022 · 6 comments

Comments

@CptPotato
Copy link
Contributor

CptPotato commented Apr 20, 2022

I seem to be unable to jump to a definition if it's not in the current workspace.

Edit: it actually turns out that goto definition has nothing to with the issue. it also happens when I open certain files.

When doing so, helix locks up for me in an infinite loop, increasing memory over time.

I'm not sure what exactly causes this, I recently updated helix, rust and rust-analyzer, so it might have something to do with that.
I'll check if I can reproduce it on a different machine later.

Minimal repro

Open helix-term/src/keymap/default.rs in helix.

os: win10 x64
hx: helix 22.05-dev (1525e3c6)

@CptPotato CptPotato changed the title goto definition in external rust source hangs helix Opening some files hangs helix Apr 20, 2022
@CptPotato
Copy link
Contributor Author

CptPotato commented Apr 20, 2022

After a quick bisect, it seems like this was introduced with c8cfd0b

\cc @the-mikedavis

@archseer
Copy link
Member

I'll roll back c8cfd0b for now

@CptPotato
Copy link
Contributor Author

I'll roll back c8cfd0b for now

Makes sense, considering the other issue related to this commit/PR.

If I can do anything to debug or provide more info, let me know.

@the-mikedavis
Copy link
Member

Whoops! 😅

Just as well with the revert, I just found some buggy behavior with the merge anyways. Do you have a custom languages.toml @CptPotato? I don't have this issue on that commit but I think it's because I don't have a custom languages.toml to merge.

@CptPotato
Copy link
Contributor Author

Yes I do have a custom languages.toml. I think the only thing I changed was setting all auto-format = true to false.

Here's the language config, if that helps: languages.toml

@the-mikedavis
Copy link
Member

Ok I'll take a look at that in #2188

Let's close this one out now since c8cfd0b is reverted (35d2693)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants