Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhelpful Theme Errors #2247

Closed
n0s4 opened this issue Apr 24, 2022 · 2 comments
Closed

Unhelpful Theme Errors #2247

n0s4 opened this issue Apr 24, 2022 · 2 comments
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements

Comments

@n0s4
Copy link
Contributor

n0s4 commented Apr 24, 2022

When writing and experimenting with themes I've noticed that if there is anything wrong with a theme (syntax error, missing key, misspelled key) and you try to select it with :theme <mytheme> the error is always:

Invalid theme: 'ui.selection' required

This message shows up even when ui.selection is present and is most of the time completely irrelevant to the actual issue with the theme. I like the theming in Helix but this makes it a lot harder to work with. I'd prefer individual errors for, say:

  • Syntax errors like missing commas, with line number.
  • Non-existent/misspelled keys.
  • Required keys that aren't implemented, specifying which key it is.
@n0s4 n0s4 added the C-enhancement Category: Improvements label Apr 24, 2022
@kirawi kirawi added the A-helix-term Area: Helix term improvements label Apr 24, 2022
@0rphee
Copy link
Contributor

0rphee commented Jul 11, 2022

For the time being I found this site useful for finding typos and errors in .tomlfiles for themes

@kirawi
Copy link
Member

kirawi commented Nov 10, 2022

Partially addressed by cargo xtask themelint introduced in #3234

@helix-editor helix-editor locked and limited conversation to collaborators Apr 16, 2024
@pascalkuthe pascalkuthe converted this issue into discussion #10460 Apr 16, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements
Projects
None yet
Development

No branches or pull requests

3 participants