Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on delete in vertically-stacked split-screen #3978

Closed
aral opened this issue Sep 26, 2022 · 2 comments · Fixed by #4570
Closed

Crash on delete in vertically-stacked split-screen #3978

aral opened this issue Sep 26, 2022 · 2 comments · Fixed by #4570
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug

Comments

@aral
Copy link
Contributor

aral commented Sep 26, 2022

Summary

  • Had same document open in top and bottom windows.
  • Deleted several lines of text from the top screen.

Error

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Line index out of bounds: line index 52, Rope/RopeSlice line count 49', /var/home/aral/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/ropey-1.5.0/src/slice.rs:424:41

Reproduction Steps

Not sure how to reproduce at the moment.

Helix log

Nothing relevant in the Helix logs.

Platform

Linux (Fedora Silverblue 37 Beta)

Terminal Emulator

Black Box

Helix Version

helix 22.08.1 (385ccdf)

@aral aral added the C-bug Category: This is a bug label Sep 26, 2022
@CptPotato
Copy link
Contributor

CptPotato commented Sep 26, 2022

This can be reproduced like this:

  • open helix
  • insert a few newlines (more than the window's height)
  • split the window (vertically or horizontally, doesn't matter)
  • in the new split jump to the start (gg)
  • delete a few lines
  • the panic occurs when the ~ end of document character goes off screen

@kirawi kirawi added the A-helix-term Area: Helix term improvements label Sep 26, 2022
@bcspragu
Copy link
Contributor

I hit this one a few times a day now, same error:

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Line index out of bounds: line index 46, Rope/RopeSlice line count 43', $HOME/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/ropey-1.5.0/src/slice.rs:424:41

Built at HEAD this morning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants