Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kanagawa theme does not follow the original creators guidelines #5280

Closed
linuscm opened this issue Dec 24, 2022 · 4 comments
Closed

Kanagawa theme does not follow the original creators guidelines #5280

linuscm opened this issue Dec 24, 2022 · 4 comments
Labels
A-theme Area: Theme and appearence related C-enhancement Category: Improvements

Comments

@linuscm
Copy link

linuscm commented Dec 24, 2022

Implementation of proper colors for git diffs are of course missing, as it is a new feature, however there are a few other things such as:

  • The model ":" suggestion menu using the same color as the background, and general menus using the wrong colors
  • indent-lines not using sumiInk4 (#54546D)
  • Cursor line having no background color, making it harder to see which line you are currently on (should use sumiInk3 #363646)
@linuscm linuscm added the C-enhancement Category: Improvements label Dec 24, 2022
@the-mikedavis the-mikedavis added the A-theme Area: Theme and appearence related label Dec 24, 2022
@leonqadirie
Copy link
Contributor

Coincidentally, I opened a related PR (#5273) just some hours ago.
Will add the indent-guides to it.

Disclaimer:
@zetashift explicitly stated this was not a 1:1 port, so their interpretations of the theme might differ.

@linuscm
Copy link
Author

linuscm commented Dec 24, 2022

Oh yeah i'm well aware saw it in the comments, but some choices just feel a bit off like the lack of a cursorline bg color and somewhat hard to see cursor.

Really just a small issue and only bring it up due some acquaintances having the same issue, It might be better to leave certain self interpretation/preferences up to adjustments within ones own config

@leonqadirie
Copy link
Contributor

TBF when the theme was ported there was no cursorline yet I think.

Most of my additions/changes incl. the cursor should be in line with the original.
Feel free to check my PR, feedback regarding the menu colors would be great.

@linuscm
Copy link
Author

linuscm commented Dec 24, 2022

Ah ok fair enough, gonna look at it further later, but from a first glance your PR looks like it makes some good adjustments and basically fixes the main issues i have myself 👍

@linuscm linuscm closed this as completed Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related C-enhancement Category: Improvements
Projects
None yet
Development

No branches or pull requests

3 participants