Go to references produce wrong highlights

[DuckDuckWhale]

Summary

Only the right portion of the line highlight in go to references are highlighted. This worked in last stable release but not current master.

Reproduction Steps

1. hx in Helix
2. Go to a variable and gr

I expected this to happen:

Whole line or just this variable is highlighted

Instead, this happened:

Highlight starts one space after the line, or when line wraps highlights also whitespaces in the middle of the wrap

Helix log

No response

Platform

Ubuntu 22.10

Terminal Emulator

Version 3.46.2 for GNOME 43

Helix Version

helix 22.12 (a4751db)

[the-mikedavis]

Could you provide an asciinema recording or video or gif? I'm not sure I understand the issue you're seeing.

Also the logs when running in verbose mode (hx -v) would be helpful since this has to do with LSP interaction: https://github.com/helix-editor/helix/wiki/FAQ#access-the-log-file

[the-mikedavis]

This might be unrelated to what you're seeing but I see in the code used by goto-definition/references/etc. that we use a point selection:

helix/helix-term/src/commands/lsp.rs

Line 206 in 2bebc50

doc.set_selection(view.id, Selection::point(new_pos));

We could use a selection on the item's range like we do for diagnostics (#4713)

[DuckDuckWhale]

Upon closer inspection, this appears to be a theming issue:

Stable Monokai:

Master Monokai (with line wrapping):

Master Monokai Pro:

[pascalkuthe]

I have a pretty good idea what is causing this and how to fix it. Will look into it later this week