Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remap keys in picker mode #615

Closed
heliostatic opened this issue Aug 18, 2021 · 8 comments · Fixed by #876
Closed

Remap keys in picker mode #615

heliostatic opened this issue Aug 18, 2021 · 8 comments · Fixed by #876
Labels
A-keymap Area: Keymap and keybindings C-enhancement Category: Improvements

Comments

@heliostatic
Copy link
Contributor

It looks from the code and in testing that there is no remap support for the picker mode. I'd like to map C-j to down (currently, C-n) in the picker. Is this a deliberate exclusion today, or simply not yet implemented?

@pickfire
Copy link
Contributor

One thing to note is that the current key remapping system is temporary, sooner or later once plugin system is implemented it will probably be trashed. Yes, remap support for sub modes is not possible yet because no one did it (not a priority of the contributors maybe?).

@pickfire pickfire added A-keymap Area: Keymap and keybindings C-enhancement Category: Improvements labels Aug 19, 2021
@cessen
Copy link
Contributor

cessen commented Aug 19, 2021

sooner or later once plugin system is implemented it will probably be trashed

I don't think that's quite right, unless I've misunderstood something. Mapping to command sequences (the work currently happening in #589, and not yet in master) will be temporary. And we may eventually move away from TOML config files. But the base keymap system itself isn't temporary, as far as I know.

In any case, I think adding support for remapping the keys in the picker is good idea. Thumbs up from me.

@pickfire
Copy link
Contributor

But the base keymap system itself isn't temporary, as far as I know.

I mean the current toml configuration will likely not be used later on. That one is temporary.

@cessen
Copy link
Contributor

cessen commented Aug 20, 2021

Ah, got it. Yes, that was my understanding as well. I guess I just think of that as more surface-level, rather than as part of the keymap system itself. But I think we're on the same page. :-)

@archseer
Copy link
Member

Let's add C-j/C-k as aliases to C-n/C-p. I think that's probably the only remap anyone would do, and it's easier to do as an alias than to make ui/picker remappable.

@heliostatic
Copy link
Contributor Author

Let's add C-j/C-k as aliases to C-n/C-p. I think that's probably the only remap anyone would do, and it's easier to do as an alias than to make ui/picker remappable.

Works for me, yep!

@idr4n
Copy link

idr4n commented Oct 6, 2022

How can I have access to this feature? C-j/C-k don't work for me (version helix 22.08.1 (66276ce) installed with homebrew)

@sudormrfbin
Copy link
Member

@idr4n The keys were removed in #1792. There's an open issue for customizing picker keys which would allow adding c-j and c-k back in: #2757.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-keymap Area: Keymap and keybindings C-enhancement Category: Improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants