Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic upon pressing n while search is set to an invalid regex #738

Closed
Omnikar opened this issue Sep 10, 2021 · 1 comment · Fixed by #740
Closed

Panic upon pressing n while search is set to an invalid regex #738

Omnikar opened this issue Sep 10, 2021 · 1 comment · Fixed by #740
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug

Comments

@Omnikar
Copy link
Contributor

Omnikar commented Sep 10, 2021

Reproduction steps

  1. Press / or s.
  2. Enter an invalid regex, such as invalid(.
  3. Press n or N. Helix panics with an error unwrap.
@Omnikar Omnikar added the C-bug Category: This is a bug label Sep 10, 2021
@pppKin
Copy link
Contributor

pppKin commented Sep 10, 2021

Can confirm. I don't think we need to unwrap the regex in search_next_impl, just do nothing and warn user of the invalid regex.

@pppKin pppKin mentioned this issue Sep 10, 2021
Merged
@kirawi kirawi added the A-helix-term Area: Helix term improvements label Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

search_next_impl: don't panic on invalid regex
3 participants
@pppKin @kirawi @Omnikar