Custom spinners

[willhansen]

I'm tired of the default braille LSP spinner. I want a custom one.

Just a configuration option that lets me input a list of strings to cycle through.

• I'd settle for one character spinners

• Better would be arbitrary length spinners (allowing stuff like a braille dot doing a figure-8 through 3 braille characters)

• Even better would be somehow incorporating colors into it. (Maybe similar to how colors are printed in zsh themes?)

Looks not too difficult to implement (if I'm not already missing an existing configuration option for it)

Relevant code I could find:

• helix/helix-term/src/ui/spinner.rs

  Line 14 in bc73740

  self.inner.entry(id).or_insert_with(Spinner::default)

• helix/helix-term/src/ui/spinner.rs

  Line 49 in bc73740

  Self::new(vec!["⣾", "⣽", "⣻", "⢿", "⡿", "⣟", "⣯", "⣷"], interval)

• helix/helix-term/src/ui/editor.rs

  Line 73 in bc73740

  spinners: ProgressSpinners::default(),

Might implement it myself.

[woojiq]

OT: I'd suggest you set lsp.display-messages to true and you won't need the spinner anymore.

[willhansen]

I already have that, but I find the spinner useful as a "thinking..." indicator. Also for aesthetic reasons.

[pascalkuthe]

I don't think these need to be configured . The spinner is just supposed to indicate that work is being done in the background (so it's clear the server is still working and hasn't crashed). The spinners are not even continuously animated) so it probably wound't look that good anyway.

We try to avoid adding too many config options and in this case the default is good enough to hardcode IMO.

[willhansen]

I can certainly agree it's not worth it if the spinner isn't even continuous.

Was that a design decision, or just not worth the effort?

[pascalkuthe]

#6446 (comment)

Not worth the extra overhead and battery life cost. This could be made more performant by allowing partial invalidation in the rendering cise but that's a lot of work