feat(editor): add config for search wrap_around #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can probably just disable the lint on that specific method |
pickfire
approved these changes
Jan 18, 2022
There was a problem hiding this comment.
I think it should be good but it might break existing users using the same config. I think maybe we want to release this as another minor update rather than patch update, otherwise we risk breaking users config, or maybe we need to have some kind of deprecation mechanism. But now I guess still too new for that.
Disabled for |
|
Thanks for working on this! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds configuration for search wrap around and moves search config into separate config struct.
Fixes: #1489