Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure :quit and :quit! take no arguments #2654

Merged
merged 1 commit into from
Jun 5, 2022

Conversation

the-mikedavis
Copy link
Member

I lost my train of thought and accidentally typed :q! :w 😄

Since quitting is a little destructive, I think it makes sense to fail the quit if it's not a well-formed 0-arg :quit(!).

What do you think?

@dylrich
Copy link
Contributor

dylrich commented Jun 3, 2022

I think this is a good idea, particularly for :q!

@archseer
Copy link
Member

archseer commented Jun 5, 2022

Agree, we should check args.len() in each command. This works as a quick fix though

@archseer archseer merged commit 1c2aaf3 into helix-editor:master Jun 5, 2022
@the-mikedavis the-mikedavis deleted the md-quit-no-arguments branch June 5, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants