Fix edge-case in tree-sitter expand_selection selection command #2877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ee-sitter nodes have the same range.
the-mikedavis
approved these changes
Jun 25, 2022
There was a problem hiding this comment.
Great catch! I was wondering why A-o was getting 'stuck' on some nodes, I thought it might've had something to do with named vs unnamed but this makes sense 👍
(One example of this:
%% f.erl
foo(Bar) ->
Bar#{a => b}.with a selection over a => b will get stuck on master).
|
Yeah, it wasn't a big deal but just irritating enough when it happened that I wanted to fix it. Thanks for the super quick review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a tree-sitter grammar outputs multiple nodes with the same range that contain each other (I noticed this with the LaTex grammar and the
textandwordnodes), theexpand_selectioncommand currently "gets stuck" at them. This happens because thedescendant_for_byte_rangefunction always returns the lowest of these nodes, so changing the selection to the range of its parent doesn't do anything.I changed it, so that now it skips nodes with identical ranges.