Add rename command.

[grv07]

#4393

Add rename command :rename new_name.txt

[the-mikedavis]

There could be a :rename!/:rnm! version that skips this check so that renaming can overwrite existing files

[grv07]

Yes, I think we can add that too.

I will continue and add them in a separate PR.
WDYT?

[grv07]

@the-mikedavis Pls let me know if you have any questions on this.

[kirawi]

I think we could also use the LSP call:
#4393 (comment)

[cor]

I think we should merge this PR instead, as it contains proper LSP support: #5531 , although it would be nice to add the shorthand :rnm from this PR to it

[the-mikedavis]

Merged in #8584 which covers this and the language server bits

[ontley]

I think that's an "issue" with the language servers themselves, not the helix lsp client.

I say "issue" because you're using an lsp feature without waiting for the language server to load properly

[David-Else]

I think that's an "issue" with the language servers themselves, not the helix lsp client.

I say "issue" because you're using an lsp feature without waiting for the language server to load properly

It still happens after the language server has loaded, note:

If you wait for ltex-ls to fully load before moving then the new file then you get 'no code actions available' but the text seems to have inherited the old underline errors?

[ontley]

That I'm not 100% certain on as rust-analyzer handles everything correctly, I think the language servers aren't responding nicely to didRenameFile, could you test a different language with lsp support?

It still happens after the language server has loaded, note:

Do you still get the errors in the log?

[David-Else]

@ontley I commented in the wrong thread, moved it to #8584 . I am away so can't continue this conversation now.