Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update diagnostic.error background for acme theme #5019

Merged
merged 3 commits into from
Dec 9, 2022
Merged

Update diagnostic.error background for acme theme #5019

merged 3 commits into from
Dec 9, 2022

Conversation

xcdkz
Copy link
Contributor

@xcdkz xcdkz commented Dec 5, 2022

Previously:
acme2

After change:
acme1

@archseer
Copy link
Member

archseer commented Dec 6, 2022

This still seems wrong to me, errors should be red?

@archseer
Copy link
Member

archseer commented Dec 6, 2022

"diagnostic.warning" and "diagnostic.info" are still broken and will render as white too

@kirawi kirawi added A-theme Area: Theme and appearence related S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 6, 2022
@xcdkz
Copy link
Contributor Author

xcdkz commented Dec 6, 2022

This still seems wrong to me, errors should be red?

I experimented a bit and came up with something like this:
image

@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 7, 2022
@the-mikedavis the-mikedavis merged commit 37e7dd1 into helix-editor:master Dec 9, 2022
herkhinah pushed a commit to herkhinah/helix that referenced this pull request Dec 11, 2022
@xcdkz
Update diagnostic.error background for acme theme (helix-editor#5019)
46bf1b4
@xcdkz xcdkz mentioned this pull request Jan 10, 2023
Closed
freqmod pushed a commit to freqmod/helix that referenced this pull request Feb 8, 2023
@xcdkz
Update diagnostic.error background for acme theme (helix-editor#5019)
2ad1ad6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xcdkz @archseer @the-mikedavis @kirawi