Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LSP completions ignoring auto-completion option #5042

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Fix LSP completions ignoring auto-completion option #5042

merged 1 commit into from
Dec 9, 2022

Conversation

Jummit
Copy link
Contributor

@Jummit Jummit commented Dec 7, 2022

Previously completions would still show when auto-completion was set to false.

@pascalkuthe pascalkuthe added S-waiting-on-review Status: Awaiting review from a maintainer. A-language-server Area: Language server client and removed A-language-server Area: Language server client labels Dec 7, 2022
the-mikedavis
the-mikedavis approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, we check this flag for completion on the idle-timeout event but not for trigger-based completion. Good catch, thanks!

@the-mikedavis the-mikedavis merged commit 2ea20a2 into helix-editor:master Dec 9, 2022
@Jummit Jummit deleted the fix-disable-completion branch December 9, 2022 10:16
herkhinah pushed a commit to herkhinah/helix that referenced this pull request Dec 11, 2022
@Jummit
Fix LSP completions ignoring auto-completion option (helix-editor#5042)
eb32779
freqmod pushed a commit to freqmod/helix that referenced this pull request Feb 8, 2023
@Jummit
Fix LSP completions ignoring auto-completion option (helix-editor#5042)
19a583b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jummit @the-mikedavis @pascalkuthe