Print the binary required by the debug adapter #5195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses issue 5193, where the author requested that the name of the binary needed is printed along with the rest of the health information. This commit adds a format! macro which formats in the name of the binary and then it will be printed along with the rest of the debug information. The value in cmd is referenced to the call to which, and then consumed upon the call to format!
the-mikedavis
approved these changes
Dec 17, 2022
There was a problem hiding this comment.
We do already say the binary name in the "Configured <protocol>: <cmd>" line above each of these but I've seen some confusion over the "not found" message like in #5913 in some matrix messages and maybe some other issues / discussions. I think this change should clear that up 👍
gibbz00
pushed a commit
to gibbz00/helix
that referenced
this pull request
Dec 17, 2022
This commit addresses issue 5193, where the author requested that the name of the binary needed is printed along with the rest of the health information. This commit adds a format! macro which formats in the name of the binary and then it will be printed along with the rest of the debug information. The value in cmd is referenced to the call to which, and then consumed upon the call to format!
hadronized
pushed a commit
to hadronized/helix
that referenced
this pull request
Jan 4, 2023
This commit addresses issue 5193, where the author requested that the name of the binary needed is printed along with the rest of the health information. This commit adds a format! macro which formats in the name of the binary and then it will be printed along with the rest of the debug information. The value in cmd is referenced to the call to which, and then consumed upon the call to format!
freqmod
pushed a commit
to freqmod/helix
that referenced
this pull request
Feb 8, 2023
This commit addresses issue 5193, where the author requested that the name of the binary needed is printed along with the rest of the health information. This commit adds a format! macro which formats in the name of the binary and then it will be printed along with the rest of the debug information. The value in cmd is referenced to the call to which, and then consumed upon the call to format!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit resolves #5193, where the author requested that the name of the binary needed is printed along with the rest of the health information.
This commit adds a
format!macro which formats in the name of the binary and then it will be printed along with the rest of the debug information. The value incmdis referenced to the call to which, and then consumed upon the call toformat!.This is my first issue in Helix, so please give feedback if this is not the kind of solution that you find optimal.