Fix diagnostic indicator background for gruvbox themes #5540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The diagnostic indicator background did not match the column or rows background colour as this was context specific, and the background for the indicator was being explicitly set. This commit removes the explicit value for the indicators background allowing it to adapt to the context. This is aligns it with other themes, and resolves the issue.
the-mikedavis
approved these changes
Jan 17, 2023
kirawi
pushed a commit
to kirawi/helix
that referenced
this pull request
Jan 25, 2023
…5540) The diagnostic indicator background did not match the column or rows background colour as this was context specific, and the background for the indicator was being explicitly set. This commit removes the explicit value for the indicators background allowing it to adapt to the context. This is aligns it with other themes, and resolves the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diagnostic indicator background did not match the column or row's background colour as this was context specific, and the background for the indicator was being explicitly set.
This commit removes the explicit value for the indicators background allowing it to adapt to the context. This aligns it with other themes, and resolves the issue.
Before:
After: