Negotiate LSP Position Encoding #5894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalkuthe
added
E-easy
pascalkuthe
force-pushed
the
encoding_negotiation
branch
2 times, most recently
from
75f2d8a
to
9b310da
Compare
So far LSP always required that `PositionEncoding.characters` is an UTF-16 offset. Now that LSP 3.17 is available in `lsp-types` request the server to send char offsets (UTF-32) or byte offsets (UTF-8) instead. For compatability with old servers, UTF-16 remains as the fallback as required by the standard.
pascalkuthe
force-pushed
the
encoding_negotiation
branch
from
9b310da
to
8ed9cc6
Compare
the-mikedavis
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far LSP always required that
PositionEncoding.charactersis an UTF-16 offset. Now that LSP 3.17 is available inlsp-typesrequest the server to send char offsets (UTF-32) or byte offsets (UTF-8) instead. For compatability with servers that don't support other encodings, UTF-16 is used as a fallback as required by the standard.