Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSP: Add request ID to request timeout message #6010

Merged
merged 1 commit into from
Feb 16, 2023
Merged

LSP: Add request ID to request timeout message #6010

merged 1 commit into from
Feb 16, 2023

Conversation

the-mikedavis
Copy link
Member

This improves error logging for requests - without the ID it's hard to know which request is the one that timed out.

This is helpful for debugging #5958 for example.

@the-mikedavis
LSP: Add request ID to request timeout message
23e9391 
This improves error logging for requests - without the ID it's hard to
know which request is the one that timed out.
@the-mikedavis the-mikedavis added C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much A-language-server Area: Language server client S-waiting-on-review Status: Awaiting review from a maintainer. labels Feb 15, 2023
pascalkuthe
pascalkuthe approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@pascalkuthe pascalkuthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that is defintly useful for debugging LSP requests and will also make logs submitted in issues more useful 👍

@archseer archseer merged commit 0f64f31 into helix-editor:master Feb 16, 2023
@the-mikedavis the-mikedavis deleted the md-lsp-request-id-in-timeout-message branch February 16, 2023 04:38
@xiaoma20082008 xiaoma20082008 mentioned this pull request Feb 16, 2023
Merged
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
@the-mikedavis @wes-adams
LSP: Add request ID to request timeout message (helix-editor#6010)
fd81c3c 
This improves error logging for requests - without the ID it's hard to
know which request is the one that timed out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalkuthe pascalkuthe pascalkuthe approved these changes

Assignees
No one assigned
Labels
A-language-server Area: Language server client C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@the-mikedavis @pascalkuthe @archseer