LSP: Separate diagnostic picker message and code #6095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dead10ck
previously approved these changes
Feb 25, 2023
FrancescElies
requested review from
dead10ck,
the-mikedavis and
poliorcetics
and removed request for
dead10ck and
the-mikedavis
the-mikedavis
approved these changes
Mar 13, 2023
the-mikedavis
changed the title
FrancescElies
deleted the
cesc/diagnostic-picker-message-code-no-separation
branch
sagnibak
pushed a commit
to sagnibak/helix
that referenced
this pull request
Mar 21, 2023
wes-adams
pushed a commit
to wes-adams/helix
that referenced
this pull request
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently in master lsp errors are reported as follows, as you can see the diagnostic message and code are attached to each other making it hard to read.
This pr solves that.
