Fix diagnostic underline colors in catppuccin themes #6107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I like the change. Do you know the official upstream repo? We should try to keep in sync. |
the-mikedavis
added
A-theme
|
@leonqadirie It seems the files in this repo are already different (usage of inheritance over templates), is there a better way to keep them in sync? Perhaps a submodule of the official repo that can be fast-forwarded? |
|
Just had a look at the upstream repo, it seems they already have this fix (slightly different syntax, but the same idea) |
the-mikedavis
approved these changes
Feb 26, 2023
the-mikedavis
changed the title
ghost
deleted the
estin
pushed a commit
to estin/helix
that referenced
this pull request
Mar 4, 2023
wes-adams
pushed a commit
to wes-adams/helix
that referenced
this pull request
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behavior sets the foreground color, and this is very difficult to read. Instead, only the underline itself should be a different color.