pin TS to unreleased git revision to fix freezes #7737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalkuthe
added
C-bug
the-mikedavis
approved these changes
Jul 25, 2023
|
I'm not opposed to this but I think it made packaging releases (on NixOS?) harder when we did this for crossterm |
|
yeah it can cause some issues forsome package management systems that are not that flexible. However, in this case there are no actual code changes involved so in the worst case they would need to patch the |
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7689
Thanks to a quick fix by @the-mikeidavis the upstream bug that was causing freezes in helix was fixed. It's fairly easy to run into this so until the next TS release we should pin a git revision that has the fix.
I used a workspace dependency so I don't have to specify the revisions twice and risk them going out of sink. Workspace dependencies is something I would like to make more use of as it helps to avoid accidental duplication of the same dependency with different versions