fix digit escapes in java & php highlights #846
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit confusingly, the
\d
escape actually needs to be\\d
to get picked up as the digit escape. As far as I can tell the\d
just gets ignored. The java regex correctly matches constants but only because it doesn't end the regex with$
. The PHP highlight currently mistreats thePI_314
in the following:as a
@constructor
instead of a@constant
.connects #845