Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging outside of the color picker stops updating the color #23

Open
gkiely opened this issue May 7, 2023 · 1 comment
Open

Dragging outside of the color picker stops updating the color #23

gkiely opened this issue May 7, 2023 · 1 comment

Comments

@gkiely
Copy link

gkiely commented May 7, 2023

In react-color if you click and drag outside of the color picker, it still updates the color.
In color-picker the updating stops and the picker freezes.

Example:
https://www.loom.com/share/8bc6a40a304944578008b01649638142

@gkiely gkiely changed the title Dragging outside of the color picker Dragging outside of the color picker stops updating the color May 7, 2023
@gkiely
Copy link
Author

gkiely commented May 7, 2023

I believe it needs to be updated to use document instead of a reference to the picker.
https://github.com/hello-pangea/color-picker/blob/main/packages/color-picker/src/components/common/Saturation.tsx#L45

The calculate change method also needs to be updated.
https://github.com/hello-pangea/color-picker/blob/main/packages/color-picker/src/helpers/saturation.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant