Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation misleading?! #68

Closed
boxcee opened this issue Nov 17, 2020 · 7 comments · Fixed by #77
Closed

Documentation misleading?! #68

boxcee opened this issue Nov 17, 2020 · 7 comments · Fixed by #77

Comments

@boxcee
Copy link
Contributor

boxcee commented Nov 17, 2020

Spent some time today fiddling around with your action.

I find the line

For more information on inputs, see the API Documentation

in the README.md a bit confusing.

For some reason I thought the inputs under the link could be used in a config file until I realized they are the options for the CLI.

Maybe the link can be removed? Or put in a different context?

@boxcee
Copy link
Contributor Author

boxcee commented Nov 17, 2020

Instead maybe link the cr CLI documentation: https://github.com/helm/chart-releaser#configuration for the config input.

@Aisuko
Copy link

Aisuko commented Mar 23, 2021

Yep, you are right. the README.md makes me a little confused.

@davidkarlsen
Copy link
Member

Instead maybe link the cr CLI documentation: https://github.com/helm/chart-releaser#configuration for the config input.

Do you want to provide a PR?

@boxcee
Copy link
Contributor Author

boxcee commented Mar 23, 2021

@davidkarlsen sure! I completely removed the (for me) confusing line though. I think it is unrelated as it documentation regarding the GitHub API and has nothing to do with the helm-chart-releaser action.

@Aisuko
Copy link

Aisuko commented Mar 24, 2021

I have a small suggestion, would you mind adding a demo to help the end-user to know how to add the parameters of release-actions.

Some like below, I believe that makes more sense.

      - name: Run chart-releaser
        uses: helm/chart-releaser-action@v1.1.0
        with:
          charts_dir: charts
          config: cr.yaml
          charts_repo_url: xxxxxx
        env:
          CR_TOKEN: "${{ secrets.GITHUB_TOKEN }}"

@boxcee
Copy link
Contributor Author

boxcee commented Apr 6, 2021

I updated the PR. Is that succifienct @Aisuko ?

@Aisuko
Copy link

Aisuko commented Apr 7, 2021

@boxcee Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants