-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to encode file as base64 string #163
Comments
@mumoshu already proposed this on roboll/helmfile#929 (comment) |
@skokhanovskiy WDYT? |
@yxxhero Sorry, but I didn't get. In the issue that @lucasfcnunes mentioned, only Could you explain? What do I should think about what?) |
It's true |
As I understand vals architecture doesn't provide any way to add "query params" globally for all providers. Each provider independently decides how to process this parameters. In #167 not so many "useful" code was added) I think this could be a good example and a source for inspiration how to implement the same logic in other providers if it's needed. |
You're right. Reading your #167 made it clear to me. |
File
provider should support encoding files as base64 string.In our project we use vals with helm and helm-secrets plugin. Sometime it's needed to delivery a binary file to a Kubernetes cluster as-is. For example, Java keystore (.jks) files.
Because of limitations in Helm (see helm/helm#3276) we deliver binary files by passing their contents as base64 string directly in Helm values as YAML.
These base64 lines can be very long, which turns the contents of YAML files into a mass of boilerplate text.
To deal with that we use vals with the
file
provider. But we couldn't just read binary file and paste its contents to values because that will break YAML completely:Before it we run a script that converts all binary files to base64 and saves results. After that we load this files by vals.
It would be nice if vals can be able to encode binary files to base64 string by itself. For example, by using parameter in the reference string:
The text was updated successfully, but these errors were encountered: