Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unnecessary gathering of distributed operand in mixed distributed/non-distributed logical functions #1064

Closed
ClaudiaComito opened this issue Dec 23, 2022 · 5 comments · Fixed by #1216
Closed

Avoid unnecessary gathering of distributed operand in mixed distributed/non-distributed logical functions #1064

ClaudiaComito opened this issue Dec 23, 2022 · 5 comments · Fixed by #1216
Assignees
@samadpls
Labels
enhancement New feature or request good first issue Good for newcomers logical memory footprint

Comments

@ClaudiaComito
Copy link
Contributor

Feature functionality

module heat.core.logical, functions allclose(x,y), isclose(x,y)

Currently, when only one of the operands is distributed, these functions (via __sanitize_close_input) gather the distributed operand and perform the global comparison on each process.

Modify the relevant functions to carry out the comparison on the relevant slice of non-distributed operand instead.
@ClaudiaComito ClaudiaComito mentioned this issue Dec 23, 2022
Merged
4 tasks
@Ishaan-Chandak
Copy link
Contributor

Hi @ClaudiaComito is this issue still open ?

@mrfh92
Copy link
Collaborator

mrfh92 commented Aug 17, 2023

This issue is stil open and useful.

(Reviewed within #1109)

@samadpls
Copy link
Contributor

samadpls commented Sep 6, 2023

Hey @ClaudiaComito and @mrfh92, can I work on this issue?

@helmholtz-analytics helmholtz-analytics deleted a comment from github-actions bot Sep 6, 2023
@ClaudiaComito ClaudiaComito added the enhancement New feature or request label Sep 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Branch features/1064-Avoid_unnecessary_gather_ing_of_distributed_operand_in_mixed_distributed/non-distributed_logical_functions created!

@ClaudiaComito
Copy link
Contributor Author

There you go @samadpls ! We'll get better at branch names when we get used to the automation 🙈

@samadpls samadpls mentioned this issue Sep 8, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samadpls samadpls

Labels
enhancement New feature or request good first issue Good for newcomers logical memory footprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enhancement: Avoid unnecessary gathering of distributed operand
4 participants
@ClaudiaComito @samadpls @Ishaan-Chandak @mrfh92