-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change data structure to be similar to the ABB API #15
Comments
Awesome! I like these. Especially functionId is cool, since this allows you to not having to know to have to know deviceId and what channels to use. However, since the value that is returned now in /info, specifically the channel-value part is an object now (instead of a number), this is a breaking change. Is it time for a 2.0 already? |
👍 I think it is. That's why I pushed it to a separate branch as it would break the current API. I think it would be fine if we allow a config option to be set to use the legacy API. Should be pretty simple to keep the legacy API as we just need to use the old XMLParser. |
It's a little more maintenance you'd have to do, and I guess you need to determine where you want to do the final mapping. Maybe do it at the 'outer' edge (SystemAccesPoint.ts), so you allow your internal model to update to the new api anyway. |
ABB has now documented parts of their Web API.
https://developer.eu.mybuildings.abb.com/getting-started
We should change the structure to be similar and also expose things like functionId and pairingId.
The text was updated successfully, but these errors were encountered: