Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x64 build installing on every run #123

Closed
drujd opened this issue Jan 17, 2019 · 7 comments
Closed

x64 build installing on every run #123

drujd opened this issue Jan 17, 2019 · 7 comments
Labels

Comments

@drujd
Copy link
Contributor

drujd commented Jan 17, 2019

I have noticed that 2.5.4 x64 version keeps chrlauncherCache.bin in temp directory after download/extraction and extracts the binaries on every run. 32-bit build does not have the problem - once I switched to 32-bit version, chrlauncher extracted the data one last time and deleted the file. Switching to x64 again will then work - until new Chromium version is released.

@drujd
Copy link
Contributor Author

drujd commented Jan 18, 2019

This bug has been introduced with 2.5.4, previous versions work fine as they cache to .zip(.tmp) file instead.

@drujd
Copy link
Contributor Author

drujd commented Jan 18, 2019

I also believe that chrlauncher should not try to install cache files that remained from previous runs and should delete the cache file before performing any update check. Even though it might save time/bandwidth by avoiding redownloading again after an error, given that the name is constant, this might introduce some serious problems with multiple instances of Chromium, possibly installing different version / type if the file was created with a different instance/configuration. If this is an intended functionality, the temp file should be local to the binary, or maybe specified in ini.

@ritmation
Copy link

I got the same issue.

@henrypp henrypp added the bug label Jan 25, 2019
@woolyss
Copy link

woolyss commented Jan 26, 2019

Hello everybody,

I haven't got this issue. Please, check my video (stored on my server) :
https://chromium.woolyss.com/f/video-74.0.3684.0-r626039-nosync-win64-marmaduke.mp4

Environment :

Please, can you share your environment or more info (screenshot, video) about your issue?

@nAFutro
Copy link

nAFutro commented Jan 28, 2019

I've had the same issue on a fresh Windows 10 x64 installation. I noticed that the chrlauncher.exe was doing a lot of reading on C:\Users\LaptopMcLapFace\AppData\Local\Temp\chrlauncherCache.bin with every launch. After deleting that file in the directory, aka the %temp% folder, chrlauncher is running as usual. (perhaps deleting only that file is not enough, I deleted every file and folder in %temp% the first time so I'm not exactly sure)

@xtcrefugee
Copy link

xtcrefugee commented Feb 1, 2019

I presume this is related to the issue I'm seeing where chrlauncher 2.5.4 x64 is starting every time I run it and remaining in the system tray, even after I exit Chromium, with current/new versions of Chromium showing as unknown unless I set ChromiumLastCheck to 0. I have chrlauncher set to check for updates but not download automatically. Reverting to 2.5.3 fixes the issue, chrlauncher exits as expected.

@drujd
Copy link
Contributor Author

drujd commented Feb 2, 2019

I can replicate this issue on 2 different computers, both Windows 10 x64 1809. Every time a new update is released, until I manually delete chrlauncherCache.bin from the temp dir. Weird, I wanted to attach a log file, but found out that it is old. Now Chrlauncher seems not to generate any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants