-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add transit encodings #2
Comments
Here's a sketch which should work. Sorry don't have time to wrap up into PR. |
@jdf-id-au your sketch has been working good for me. I have forked your gist to make a couple small changes and add a deps.edn, so that it can be used in a project via the following git dep:
I could put together a PR for this if desired. |
Cool, I would certainly accept a PR, but clearly this works as is, so no great hurry |
I released a separate library to do this. https://github.com/Motiva-AI/pipeline-transit/blob/master/src/pipeline_transit/core.clj I'm not sure if this feature should go into this library though. Not everyone needs to use transit with time-literals and adding it would require roping in the transit-clj and cljs libraries for this use case. Thus bloating this library. |
Thanks. I agree wrt dependencies. I think what I'll do is link from the README and close this issue. I notice the file you link to is just clj, rather than cljc as the gist further up was. |
Here is an implementation that is working for myself (it works with cljc): |
No description provided.
The text was updated successfully, but these errors were encountered: