Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add transit encodings #2

Open
henryw374 opened this issue Aug 15, 2019 · 6 comments
Open

add transit encodings #2

henryw374 opened this issue Aug 15, 2019 · 6 comments
Labels
enhancement New feature or request

Comments

@henryw374
Copy link
Owner

No description provided.

@henryw374 henryw374 added the enhancement New feature or request label Aug 15, 2019
@jdf-id-au
Copy link

Here's a sketch which should work. Sorry don't have time to wrap up into PR.

@jjttjj
Copy link

jjttjj commented Jan 14, 2020

@jdf-id-au your sketch has been working good for me. I have forked your gist to make a couple small changes and add a deps.edn, so that it can be used in a project via the following git dep:

  transit-connection {:git/url "https://gist.github.com/jjttjj/6bc0b62ef1dbf29c1c69ea22f8eb7f55"
                      :sha "2345014effd1ce7089d2b847808d4bbcf2c38a3b"}

I could put together a PR for this if desired.

@henryw374
Copy link
Owner Author

Cool, I would certainly accept a PR, but clearly this works as is, so no great hurry

@Quantisan
Copy link

I released a separate library to do this. https://github.com/Motiva-AI/pipeline-transit/blob/master/src/pipeline_transit/core.clj

I'm not sure if this feature should go into this library though. Not everyone needs to use transit with time-literals and adding it would require roping in the transit-clj and cljs libraries for this use case. Thus bloating this library.

@henryw374
Copy link
Owner Author

I released a separate library to do this. https://github.com/Motiva-AI/pipeline-transit/blob/master/src/pipeline_transit/core.clj

I'm not sure if this feature should go into this library though. Not everyone needs to use transit with time-literals and adding it would require roping in the transit-clj and cljs libraries for this use case. Thus bloating this library.

Thanks. I agree wrt dependencies.

I think what I'll do is link from the README and close this issue.

I notice the file you link to is just clj, rather than cljc as the gist further up was.

@awb99
Copy link

awb99 commented Sep 5, 2023

Here is an implementation that is working for myself (it works with cljc):
https://github.com/pink-gorilla/modular/blob/main/src/modular/encoding/time2.cljc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants