Pip 10 being installed

[harrywhite4]

This buildpack is currently installing pip 10, but looking through the scripts it seems like it was supposed to be set at 9.0.2 not sure if using pip 10 is intended or not

We are having some issues installing git dependencies with the new version of pip as described here pypa/pip#5251

I have tried disabling the buildpacks install to manually get pip 9, but looking at the pipenv script skip_pipenv_install is set back to 1 when there are git dependencies.

[edmorley]

It looks like the get-pip.py invocation here should be passing pip==<version>:

heroku-buildpack-python/bin/steps/python

Line 70 in 9eddeae

/app/.heroku/python/bin/python "$ROOT_DIR/vendor/get-pip.py" &> /dev/null

[makmanalp]

@edmorley is passing pip==version to get-pip.py an option? I was under the impression that the get-pip.py bundled all the code within it.

[edmorley]

Yes:
https://github.com/pypa/get-pip/blob/ba67ea6b49a0caa1c3be638b9f913590a8af624e/templates/default.py#L130-L154

The problem is that the pip that's bundled with get-pip.py self-upgrades:
https://github.com/pypa/get-pip/blob/ba67ea6b49a0caa1c3be638b9f913590a8af624e/templates/default.py#L157

[kennethreitz]

Nice catch, @edmorley! Will update this.

[kennethreitz]

This is now resolved.