Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - disableAnimation prop not working in Button component #3489

Closed
tovaschreier opened this issue Jul 17, 2024 · 1 comment · Fixed by #3499
Closed

[BUG] - disableAnimation prop not working in Button component #3489

tovaschreier opened this issue Jul 17, 2024 · 1 comment · Fixed by #3499
Assignees

Comments

@tovaschreier
Copy link

NextUI Version

@nextui-org/button@2.0.31

Describe the bug

The button's disableAnimation prop should disable the rescaling animation on press. However, we currently need to add a data-[pressed=true]:scale-100 class override as well in order to achieve that.

  • I traced it to this line in the button component's source code, which seems to be getting applied even when we pass disableAnimation, likely due to this change
  • I believe that change accidentally broke the expected behavior of the disableAnimation prop, and would request that you re-disable the scaling behavior on press when disableAnimation is false.

Your Example Website or App

No response

Steps to Reproduce the Bug or Issue

You can see it not working in Storybook. It seems like it removes the smooth transition but keeps the button resizing on press effect.

Expected behavior

I would expect the button not to resize on press when disableAnimation is passed in.

Screenshots or Videos

No response

Operating System Version

MacOS

Browser

Chrome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants