[BUG] - Select opens and closes instantly when clicking on the label

[danielantelo]

NextUI Version

2.4.6 2.4.8

Describe the bug

Just upgraded to the latest version and now my Selects are not behaving properly. When I click on the label of a Select it used to Open and allow user to select an option. Now it opens and instantly closes. I see it is also happening on your Docs website.

Your Example Website or App

https://nextui.org/docs/components/select

Steps to Reproduce the Bug or Issue

1. Go to https://nextui.org/docs/components/select
2. Click on the label of any of the Selects
3. Notice how it opens and closes instantly

Expected behavior

When you click on the Label it should remain open.

Screenshots or Videos

Screen.Recording.2024-07-25.at.16.59.31.mov

Operating System Version

MacOS

Browser

Chrome

[linear]

ENG-1205 [BUG] - Select opens and closes instantly when clicking on the label

[wingkwong]

can ref to ariaShouldCloseOnInteractOutside logic. the trigger is only on input so label is considered outside.

[sohan01fw]

@wingkwong can u assign this to me? i solved it. Need to raise pr

[sohan01fw]

@wingkwong i have one question do i need to run test and build to the specific component that i made changes or whole? cause during build of whole project got error but not while doing on specific component that i made changes on!

[wingkwong]

@sohan01fw of course all test cases have to be passed. If some that you haven't changed fail, then some underlying logic may be changed. You may double check.

[sohan01fw]

i don't like this i don't know why the error still presist even tho i freshly fork and clone repo again and try to build the project without made any changes throw some weird error like this

[wingkwong]

@sohan01fw if so, then probably it's related to your local environment rather than your PR. Can yo make a PR so that it could run in github actions to see if the errors are still there?

[Gaic4o]

During QA testing on the service, this problem was discovered. I hope it gets resolved quickly.

[kanstantsinkamazennikau]

Perhaps there is some sort of fix that can be used now before the PR merged?

[abhinav700]

@wingkwong I notice that you have rolled back the associated PR.
Is this issue still open?

[wingkwong]

@abhinav700 yep. thanks for the catch.

[abhinav700]

@wingkwong Ok. I will begin investigating the issue. Will update if I find something. Right now I am looking into ariaShouldCloseOnInteractOutside to get better context and implement the solution suggested by you.

[abhinav700]

@wingkwong It seems like I cannot reproduce this issue on my local machine, even though I have synced my branch and pulled the changes.

Maybe it is fixed in some other PR which was not referencing this issue using a #.

Screencast.2024-09-24.12.02.21.mp4

[wingkwong]

just checked. the only i rolled back is 3658, not 3568, which just mentioned by coderabbit only.

[abhinav700]

@wingkwong ok.