From 8bfaa9feb8b080fb5b0d70576e926f3bd63972bc Mon Sep 17 00:00:00 2001 From: Artem Pitikin Date: Thu, 16 May 2024 12:59:37 +0300 Subject: [PATCH 1/7] fix(checkbox): make VisuallyHidden's element type as span --- packages/components/checkbox/src/checkbox.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/components/checkbox/src/checkbox.tsx b/packages/components/checkbox/src/checkbox.tsx index dea6db536e..9ca4ee6e2a 100644 --- a/packages/components/checkbox/src/checkbox.tsx +++ b/packages/components/checkbox/src/checkbox.tsx @@ -26,7 +26,7 @@ const Checkbox = forwardRef<"input", CheckboxProps>((props, ref) => { return ( - + {clonedIcon} From 6ea4a617aff1d4669992b5a0c7a80c621b87edc6 Mon Sep 17 00:00:00 2001 From: Artem Pitikin Date: Thu, 16 May 2024 13:07:50 +0300 Subject: [PATCH 2/7] feat(changeset): add changeset --- .changeset/fluffy-seals-complain.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/fluffy-seals-complain.md diff --git a/.changeset/fluffy-seals-complain.md b/.changeset/fluffy-seals-complain.md new file mode 100644 index 0000000000..c1cc9bdcb4 --- /dev/null +++ b/.changeset/fluffy-seals-complain.md @@ -0,0 +1,5 @@ +--- +"@nextui-org/checkbox": patch +--- + +make VisuallyHidden's element type as span From d047e868f4313f48be309e86702c223887a0ed57 Mon Sep 17 00:00:00 2001 From: Artem Pitikin Date: Thu, 16 May 2024 13:40:02 +0300 Subject: [PATCH 3/7] fix(radio): make the VisuallyHidden element type as span --- packages/components/radio/src/radio.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/components/radio/src/radio.tsx b/packages/components/radio/src/radio.tsx index 42b108f959..a72bc656dd 100644 --- a/packages/components/radio/src/radio.tsx +++ b/packages/components/radio/src/radio.tsx @@ -22,7 +22,7 @@ const Radio = forwardRef<"input", RadioProps>((props, ref) => { return ( - + From d25e5abedbaf6cf59125923b1837e43e94949349 Mon Sep 17 00:00:00 2001 From: Artem Pitikin Date: Thu, 16 May 2024 13:40:27 +0300 Subject: [PATCH 4/7] fix(switch): make the VisuallyHidden element type as span --- packages/components/switch/src/switch.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/components/switch/src/switch.tsx b/packages/components/switch/src/switch.tsx index bee6a80bae..d60428bfcd 100644 --- a/packages/components/switch/src/switch.tsx +++ b/packages/components/switch/src/switch.tsx @@ -35,7 +35,7 @@ const Switch = forwardRef<"input", SwitchProps>((props, ref) => { return ( - + From 25fef8b4a55972f9ea541d2158112ccbfa1eaa21 Mon Sep 17 00:00:00 2001 From: Artem Pitikin Date: Thu, 16 May 2024 13:51:36 +0300 Subject: [PATCH 5/7] fix(select): make the VisuallyHidden element type as span --- packages/components/select/src/select.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/components/select/src/select.tsx b/packages/components/select/src/select.tsx index bda7b15277..d83bc8ef96 100644 --- a/packages/components/select/src/select.tsx +++ b/packages/components/select/src/select.tsx @@ -131,7 +131,7 @@ function Select(props: Props, ref: ForwardedRef {renderSelectedItem} - {state.selectedItems && ,} + {state.selectedItems && ,} {endContent} From 7b3b5d1b11bdd05868018aa4a371dcd80ba0d13c Mon Sep 17 00:00:00 2001 From: Artem Pitikin Date: Thu, 16 May 2024 13:56:32 +0300 Subject: [PATCH 6/7] feat(changeset): replace changeset --- .changeset/fluffy-seals-complain.md | 5 ----- .changeset/thick-frogs-jog.md | 8 ++++++++ 2 files changed, 8 insertions(+), 5 deletions(-) delete mode 100644 .changeset/fluffy-seals-complain.md create mode 100644 .changeset/thick-frogs-jog.md diff --git a/.changeset/fluffy-seals-complain.md b/.changeset/fluffy-seals-complain.md deleted file mode 100644 index c1cc9bdcb4..0000000000 --- a/.changeset/fluffy-seals-complain.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -"@nextui-org/checkbox": patch ---- - -make VisuallyHidden's element type as span diff --git a/.changeset/thick-frogs-jog.md b/.changeset/thick-frogs-jog.md new file mode 100644 index 0000000000..6b59f94d5c --- /dev/null +++ b/.changeset/thick-frogs-jog.md @@ -0,0 +1,8 @@ +--- +"@nextui-org/checkbox": patch +"@nextui-org/radio": patch +"@nextui-org/select": patch +"@nextui-org/switch": patch +--- + +make the VisuallyHidden `elementType` as span when the default parent element accepts only phrasing elements From 0cfd6e1ad5da454fa005a865f27d909845bca92c Mon Sep 17 00:00:00 2001 From: Artem Pitikin Date: Mon, 20 May 2024 14:21:55 +0300 Subject: [PATCH 7/7] chore: fix formatting --- packages/components/select/src/select.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/components/select/src/select.tsx b/packages/components/select/src/select.tsx index b3eb251e89..925fb0abbf 100644 --- a/packages/components/select/src/select.tsx +++ b/packages/components/select/src/select.tsx @@ -130,7 +130,9 @@ function Select(props: Props, ref: ForwardedRef {startContent} {renderSelectedItem} - {endContent && state.selectedItems && ,} + {endContent && state.selectedItems && ( + , + )} {endContent} {renderIndicator}