From d9d41d574c4da06f5965cd6a00aa097a56334341 Mon Sep 17 00:00:00 2001
From: WK Wong <wingkwong.code@gmail.com>
Date: Tue, 14 Jan 2025 00:46:53 +0800
Subject: [PATCH 1/5] fix(use-aria-link): onClick deprecation warning

---
 packages/hooks/use-aria-link/src/index.ts | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/packages/hooks/use-aria-link/src/index.ts b/packages/hooks/use-aria-link/src/index.ts
index eb3d9e1c64..c0b5bba47a 100644
--- a/packages/hooks/use-aria-link/src/index.ts
+++ b/packages/hooks/use-aria-link/src/index.ts
@@ -21,6 +21,8 @@ export interface AriaLinkOptions extends AriaLinkProps {
   isDisabled?: boolean;
   /** The role of the element */
   role?: string;
+  /** The type of the element, e.g. 'button' */
+  type?: string;
   /**
    * The HTML element used to render the link, e.g. 'a', or 'span'.
    * @default 'a'
@@ -50,6 +52,7 @@ export function useAriaLink(props: AriaLinkOptions, ref: RefObject<FocusableElem
     onClick: deprecatedOnClick,
     role,
     isDisabled,
+    type,
     ...otherProps
   } = props;
 
@@ -64,7 +67,14 @@ export function useAriaLink(props: AriaLinkOptions, ref: RefObject<FocusableElem
 
   let isMobile = isIOS() || isAndroid();
 
-  if (deprecatedOnClick && typeof deprecatedOnClick === "function" && role !== "button") {
+  if (
+    deprecatedOnClick &&
+    typeof deprecatedOnClick === "function" &&
+    // bypass since onClick is passed from <Link as="button" /> internally
+    type !== "button" &&
+    // bypass since onClick is passed from <Button as={Link} /> internally
+    role !== "button"
+  ) {
     warn(
       "onClick is deprecated, please use onPress instead. See: https://github.com/nextui-org/nextui/issues/4292",
       "useLink",

From 0b2a967661dd6a47b177f1147cd0da7365d1956e Mon Sep 17 00:00:00 2001
From: WK Wong <wingkwong.code@gmail.com>
Date: Tue, 14 Jan 2025 00:47:04 +0800
Subject: [PATCH 2/5] fix(use-aria-button): onClick deprecation warning

---
 packages/hooks/use-aria-button/src/index.ts | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/packages/hooks/use-aria-button/src/index.ts b/packages/hooks/use-aria-button/src/index.ts
index 03593113b0..c37b257ce5 100644
--- a/packages/hooks/use-aria-button/src/index.ts
+++ b/packages/hooks/use-aria-button/src/index.ts
@@ -19,6 +19,8 @@ import {usePress} from "@react-aria/interactions";
 export type AriaButtonProps<T extends ElementType = "button"> = BaseAriaButtonProps<T> & {
   /** Whether text selection should be enabled on the pressable element. */
   allowTextSelectionOnPress?: boolean;
+  /** The role of the button element. */
+  role?: string;
 };
 
 export interface ButtonAria<T> {
@@ -81,6 +83,7 @@ export function useAriaButton(
     rel,
     type = "button",
     allowTextSelectionOnPress,
+    role,
   } = props;
   let additionalProps;
 
@@ -104,7 +107,14 @@ export function useAriaButton(
 
   let isMobile = isIOS() || isAndroid();
 
-  if (deprecatedOnClick && typeof deprecatedOnClick === "function") {
+  if (
+    deprecatedOnClick &&
+    typeof deprecatedOnClick === "function" &&
+    // bypass since onClick is passed from <Link as={Button} /> internally
+    role !== "link" &&
+    // bypass since onClick is passed from useDisclosure's `getButtonProps` internally
+    !(props.hasOwnProperty("aria-controls") && props.hasOwnProperty("aria-controls"))
+  ) {
     warn(
       "onClick is deprecated, please use onPress instead. See: https://github.com/nextui-org/nextui/issues/4292",
       "useButton",

From 1f35a33f30055c71a71e2fbf1ffee3c227ed5e31 Mon Sep 17 00:00:00 2001
From: WK Wong <wingkwong.code@gmail.com>
Date: Tue, 14 Jan 2025 00:48:19 +0800
Subject: [PATCH 3/5] feat(changeset): add changeset

---
 .changeset/stale-moose-hear.md | 6 ++++++
 1 file changed, 6 insertions(+)
 create mode 100644 .changeset/stale-moose-hear.md

diff --git a/.changeset/stale-moose-hear.md b/.changeset/stale-moose-hear.md
new file mode 100644
index 0000000000..807e18a855
--- /dev/null
+++ b/.changeset/stale-moose-hear.md
@@ -0,0 +1,6 @@
+---
+"@nextui-org/use-aria-button": patch
+"@nextui-org/use-aria-link": patch
+---
+
+avoid showing onClick deprecation warning for internal onClick (#4549, #4546)

From f1a7309ba256d5e32d370992cde16f01556feaf7 Mon Sep 17 00:00:00 2001
From: WK Wong <wingkwong.code@gmail.com>
Date: Tue, 14 Jan 2025 01:00:14 +0800
Subject: [PATCH 4/5] fix(use-aria-button): incorrect prop name

---
 packages/hooks/use-aria-button/src/index.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/hooks/use-aria-button/src/index.ts b/packages/hooks/use-aria-button/src/index.ts
index c37b257ce5..2181bc91a9 100644
--- a/packages/hooks/use-aria-button/src/index.ts
+++ b/packages/hooks/use-aria-button/src/index.ts
@@ -113,7 +113,7 @@ export function useAriaButton(
     // bypass since onClick is passed from <Link as={Button} /> internally
     role !== "link" &&
     // bypass since onClick is passed from useDisclosure's `getButtonProps` internally
-    !(props.hasOwnProperty("aria-controls") && props.hasOwnProperty("aria-controls"))
+    !(props.hasOwnProperty("aria-expanded") && props.hasOwnProperty("aria-controls"))
   ) {
     warn(
       "onClick is deprecated, please use onPress instead. See: https://github.com/nextui-org/nextui/issues/4292",

From 87c1bf08153e3449030b583a1488baa1a79f598f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=D5=A1=D3=84=D5=A1?= <wingkwong.code@gmail.com>
Date: Sat, 18 Jan 2025 21:01:17 +0800
Subject: [PATCH 5/5] chore(changeset): update package name

---
 .changeset/stale-moose-hear.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.changeset/stale-moose-hear.md b/.changeset/stale-moose-hear.md
index 807e18a855..b885593d9f 100644
--- a/.changeset/stale-moose-hear.md
+++ b/.changeset/stale-moose-hear.md
@@ -1,6 +1,6 @@
 ---
-"@nextui-org/use-aria-button": patch
-"@nextui-org/use-aria-link": patch
+"@heroui/use-aria-button": patch
+"@heroui/use-aria-link": patch
 ---
 
 avoid showing onClick deprecation warning for internal onClick (#4549, #4546)