Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 2.4.0 #231

Merged
merged 1 commit into from
Aug 21, 2020
Merged

release: 2.4.0 #231

merged 1 commit into from
Aug 21, 2020

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh requested a review from a team August 17, 2020 11:58
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.436% when pulling b486348 on curbengh:v2.4.0 into a96335d on hexojs:master.

@SukkaW
Copy link
Member

SukkaW commented Aug 17, 2020

Should #229 being considered as Breaking Changes?

hexojs/hexo has no package.json and dependencies is not pinned. If Hexo user installs the latest hexo-util their theme might be broken.

@curbengh
Copy link
Contributor Author

curbengh commented Aug 18, 2020

Should #229 being considered as Breaking Changes?

I believe I'm the only affected user 😅

caption in { wrap: false } config was only introduced recently in 2.2.0 and it's not mentioned in hexo.io yet, so the breaking change is fairly minimal.

#229 doesn't affect the default { wrap: true} highlight.js config.

@SukkaW
Copy link
Member

SukkaW commented Aug 18, 2020

caption in { wrap: false } config was only introduced recently in 2.2.0 and it's not mentioned in hexo.io yet, so the breaking change is fairly minimal.

However there might be users who already uses caption white recently changed to wrap: false. Then caption could "come from nowhere" and break the theme.

@curbengh
Copy link
Contributor Author

...already uses caption while recently changed to wrap: false, then caption could "come from nowhere"

if they already use caption, shouldn't they expect caption to be displayed (as introduced in #210)? Switching to wrap: false requires a significant change to the theme and hardly any theme supports it because it doesn't support line number.

It doesn't necessarily break the theme, more of a missing style. since caption in wrap: false was not supported previously, the only users who would style the caption are the ones who closely follow this repo, and if they already closely following, it should fairly trivial for them to update caption style after #229. #229 is indeed a breaking change for them, but the change is too minimal to justify bumping major.

@curbengh curbengh merged commit 19315b8 into hexojs:master Aug 21, 2020
@curbengh curbengh deleted the v2.4.0 branch August 21, 2020 03:08
@curbengh
Copy link
Contributor Author

nevilm-lt pushed a commit to nevilm-lt/hexo-util that referenced this pull request Apr 22, 2022
nevilm-lt pushed a commit to nevilm-lt/hexo-util that referenced this pull request Apr 22, 2022
nevilm-lt pushed a commit to nevilm-lt/hexo-util that referenced this pull request Apr 22, 2022
nevilm-lt pushed a commit to nevilm-lt/hexo-util that referenced this pull request Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants