Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve coverage #4421

Merged
merged 1 commit into from
Jul 15, 2020
Merged

test: improve coverage #4421

merged 1 commit into from
Jul 15, 2020

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Jul 15, 2020

What does it do?

#3984

Continuation of #4050

How to test

git clone -b test-coverage-1 https://github.com/sukkaw/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@SukkaW SukkaW requested review from curbengh and a team July 15, 2020 15:54
stevenjoezhang
stevenjoezhang previously approved these changes Jul 15, 2020
@SukkaW
Copy link
Member Author

SukkaW commented Jul 15, 2020

@stevenjoezhang GitHub downs again and causes all tests are hanged.

I will merge the PR after GitHub's services restored and tests are finished.

@stevenjoezhang
Copy link
Member

It is up to you to decide~
I tested it locally and the new test cases work as expected

@SukkaW
Copy link
Member Author

SukkaW commented Jul 15, 2020

I tested it locally and the new test cases work as expected

Well, I need to see coverage change from coverage bot's report.

@SukkaW
Copy link
Member Author

SukkaW commented Jul 15, 2020

It appears that the GitHub's services is now restored and the PR is now able to track the changes.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 97.993% when pulling 2d81d7d on SukkaW:test-coverage-1 into 89b2a9a on hexojs:master.

@SukkaW SukkaW merged commit a8d918b into hexojs:master Jul 15, 2020
@SukkaW SukkaW mentioned this pull request Jul 16, 2020
2 tasks
@SukkaW SukkaW mentioned this pull request Jul 25, 2020
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants