Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Failed to create post with special character title #5149

Merged
merged 1 commit into from
Feb 6, 2023
Merged

fix: Failed to create post with special character title #5149

merged 1 commit into from
Feb 6, 2023

Conversation

D-Sketon
Copy link
Member

What does it do?

try to fix #5120

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@github-actions
Copy link

How to test

git clone -b fix_5120 https://github.com/D-Sketon/hexo.git
cd hexo
npm install
npm test

@coveralls
Copy link

Coverage Status

Coverage: 98.769% (+0.04%) from 98.733% when pulling b64a7f3 on D-Sketon:fix_5120 into 4f2dde4 on hexojs:master.

yoshinorin
yoshinorin approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you :)

@yoshinorin yoshinorin merged commit d5f3f82 into hexojs:master Feb 6, 2023
@yoshinorin yoshinorin added this to the 7.0.0 milestone Feb 15, 2023
@D-Sketon D-Sketon deleted the fix_5120 branch June 3, 2023 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

Failed to create post with special character title
3 participants
@D-Sketon @coveralls @yoshinorin