Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/fix 165 fill value must be scalar #187

Merged

Conversation

burnpanck
Copy link
Contributor

@andrewgsavage
Copy link
Collaborator

Is that the only place you encouter issues with force_ndarray_like = True? Would it be worth running all the pandas extension tests with force_ndarray_like = True?

@burnpanck
Copy link
Contributor Author

Indeed, it may be reasonable to run the whole test-suite both with and without force_ndarray_like = True. Without this fix, many of the tests fail, but it always appeared to be the same error; missing values is an important feature within pandas. I think all issues may be fixed now, but I actually didn't run the whole test-suite with that flag after the fix at all. Do you know of a good way of passing a "feature flag" to a global pytest fixture, so that we can just simply run the whole test-suite twice?

@andrewgsavage
Copy link
Collaborator

I'm not aware of one, and the options I found googling didn't look suitable. I'll open a new issue for it.

@andrewgsavage
Copy link
Collaborator

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 22, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 44f0f9b into hgrecco:master Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"ValueError: fill_value must be a scalar" when concatenating columns requiring fill
2 participants