Skip to content
This repository has been archived by the owner on Jul 22, 2020. It is now read-only.

Make consistency level configurable #20

Closed
james-hu opened this issue Oct 11, 2016 · 4 comments
Closed

Make consistency level configurable #20

james-hu opened this issue Oct 11, 2016 · 4 comments

Comments

@james-hu
Copy link
Contributor

Make it configurable: consistency level for schema version tracking statements

Currently it is hard coded to ALL, making it configurable gives us possibilities to work around some issues (in very sick use cases, I have to admit).

I have a quick implementation here: https://github.com/james-hu/cassandra-migration/pull/1/files
But probably the configuration should be on CassandraMigration rather than on KeyspaceConfiguration. Then we can pass it as an argument to the constructor of SchemaVersionDAO. That change seems to be a little bit structural. So I think I'd better let you take over.


## Definition of Done

Consistency level is configurable from Java (and command line as well?)


## Out of Scope

Consistency level of migrations scripts provided by the users.


## How to Demo

Create a keyspace that can't satisfy the ConsistencyLevel.ALL, and try to make migration success by setting consistency level to QUORUM.

@smiklosovic
Copy link
Contributor

@hhandoko we need this badly, please release this as soon as possible

@hhandoko
Copy link
Owner

Thanks for reaching out @smiklosovic , I'm just a bit inundated at work right now. If you could draft a PR it would really help me 😄 Otherwise, I'll try to get to this on my next opportunity.

@hhandoko
Copy link
Owner

Partly implemented in #46 . I might expand this to accept user-defined values over configuration files.

@hhandoko
Copy link
Owner

hhandoko commented Mar 2, 2017

Implemented in #48.

@hhandoko hhandoko closed this as completed Mar 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants