Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not abap cloud compatible #21

Closed
ArneVanH opened this issue Jun 6, 2023 · 2 comments
Closed

Not abap cloud compatible #21

ArneVanH opened this issue Jun 6, 2023 · 2 comments

Comments

@ArneVanH
Copy link

ArneVanH commented Jun 6, 2023

Hi,

We pulled this repo as it was marked as cloud compatible on dotabap.org, however concluded that it is in fact not (no longer?) cloud compatible.

With the following changes we were able to get a working version:

  • replace some data elements with cloud released data elements
  • replace retrieval code of interface implementation list with:
    classes_list = xco_cp_abap=>interface( 'ZIF_ADV_CHECK' )->implementations->all->get_names( ).
  • find cloud enabled apis for date and time plausibility (we have, for the moment, simply deactivated these checks...)
  • http check -> we completely removed this check because "if_http_entity" and related objects are not released, so a complete rework is probably needed..

In either case, we got it up and running relatively quickly - so thanks!

@hhelibeb
Copy link
Owner

hhelibeb commented Jun 7, 2023

Hi @ArneVanH, I'm very glad to hear that someone else is using the repo besides myself.😄

Thank you for providing details regarding compatibility. I'm not sure how dotabap determines the "cloud ready" flag. I will add the information you've provided to README , and will look into how to improve the code accordingly.

In the meantime, if you're interested, feel free to fork this repo and replace the files with your cloud-compatible version. I believe this would be helpful for developers who are using ABAP Cloud.

@ArneVanH
Copy link
Author

ArneVanH commented Jun 7, 2023

Created a pull request after making changes for cloud compatibility.
Couldn't test if the cloud-APIs exist on non-cloud systems -> so maybe not an interesting pull to accept if not..

@ArneVanH ArneVanH closed this as completed Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants