fix(react-server): noramlize client reference with ?t= query (hmr timestamp)
#316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi-ogawa
changed the title
?t= query (hmr timestamp)
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
?importquery dual package when client module is used at both boundary and non-boundary #315Probably we should consider entirely virtual module centered approach (not only
node_modules), but for now, it might be possible to simply adjust our existingnoramlizeClientReferenceIdto take hmr timestamp into account.However,
?t=...injection doesn't happen for ssr import analysis (unless we use new module runnerinjectInvalidationTimestampmode vitejs/vite#16400), so we actually need to strip that out during ssrimportWrapperagain.And good news is that this is going to fix this non-ideal HMR behavior added in: