From d6a9d41fbacc0715330e188daa1d5713edf1ae3b Mon Sep 17 00:00:00 2001 From: Guillaume Smet Date: Fri, 15 Jan 2021 19:46:19 +0100 Subject: [PATCH] HV-1826 Reintroduce TCK Runner in container tests --- distribution/pom.xml | 4 ++- integration/pom.xml | 26 ++++++-------- integration/src/test/resources/arquillian.xml | 13 +++---- modules/pom.xml | 34 ++++++++++++++----- .../main/modules/wildfly-current-patch.xml | 2 +- .../main/modules/wildfly-secondary-patch.xml | 2 +- modules/src/script/setupModules.groovy | 4 +-- pom.xml | 12 ++++--- tck-runner/pom.xml | 10 +++--- .../src/script/updateStandaloneXml.groovy | 2 +- .../modules/jdk11/javafx/api/main/module.xml | 2 +- 11 files changed, 62 insertions(+), 49 deletions(-) diff --git a/distribution/pom.xml b/distribution/pom.xml index 2036200c8f..b5ef8efdf6 100644 --- a/distribution/pom.xml +++ b/distribution/pom.xml @@ -89,15 +89,17 @@ ${project.groupId} hibernate-validator-modules - wildfly-${version.wildfly}-patch + wildfly-preview-${version.wildfly}-patch zip + diff --git a/integration/pom.xml b/integration/pom.xml index 84e0b15e7a..5f357c7ad6 100644 --- a/integration/pom.xml +++ b/integration/pom.xml @@ -21,16 +21,14 @@ Hibernate Validator WildFly integration tests. - ${project.build.directory}/wildfly-${version.wildfly} + ${project.build.directory}/wildfly-preview-${version.wildfly} ${wildfly.target-dir}/modules/system/layers/base - + .. - - - true @@ -158,7 +156,7 @@ ${project.groupId} hibernate-validator-modules - wildfly-${version.wildfly}-patch + wildfly-preview-${version.wildfly}-patch zip test @@ -220,7 +218,7 @@ org.wildfly - wildfly-dist + wildfly-preview-dist ${version.wildfly} tar.gz false @@ -242,7 +240,7 @@ ${project.groupId} hibernate-validator-modules ${project.version} - wildfly-${version.wildfly}-patch + wildfly-preview-${version.wildfly}-patch zip ${project.build.directory} @@ -310,10 +308,10 @@ true - ${project.build.directory}/wildfly-${version.wildfly}/ + ${project.build.directory}/wildfly-preview-${version.wildfly}/ false - patch apply ${project.build.directory}/hibernate-validator-modules-${project.version}-wildfly-${version.wildfly}-patch.zip + patch apply ${project.build.directory}/hibernate-validator-modules-${project.version}-wildfly-preview-${version.wildfly}-patch.zip @@ -333,6 +331,7 @@ + wildfly-secondary-integration-test @@ -371,7 +369,6 @@ - org.wildfly wildfly-dist @@ -391,7 +388,6 @@ - ${project.groupId} hibernate-validator-modules @@ -411,7 +407,6 @@ - javax.money money-api @@ -432,7 +427,6 @@ maven-resources-plugin - copy-wildfly-secondary-resources pre-integration-test @@ -455,7 +449,6 @@ org.wildfly.plugins wildfly-maven-plugin - apply-wildfly-secondary-patch-file pre-integration-test @@ -476,5 +469,6 @@ + --> diff --git a/integration/src/test/resources/arquillian.xml b/integration/src/test/resources/arquillian.xml index 9116248ee6..e00169a55c 100644 --- a/integration/src/test/resources/arquillian.xml +++ b/integration/src/test/resources/arquillian.xml @@ -22,9 +22,9 @@ REMOTE - ${basedir}/target/wildfly-${version.wildfly} + ${wildfly.target-dir} - -Dee8.preview.mode=true ${arquillian.wildfly.jvm.args} + ${arquillian.wildfly.jvm.args} - + + --> diff --git a/modules/pom.xml b/modules/pom.xml index 9eaefd9dfe..a9396ba81f 100644 --- a/modules/pom.xml +++ b/modules/pom.xml @@ -25,14 +25,16 @@ ${project.build.directory}/modules - ${project.build.directory}/wildfly-original/wildfly-${version.wildfly} - ${project.build.directory}/wildfly-patched/wildfly-${version.wildfly} - ${project.build.directory}/wildfly-current-hv-patch.zip + ${project.build.directory}/wildfly-original/wildfly-preview-${version.wildfly} + ${project.build.directory}/wildfly-patched/wildfly-preview-${version.wildfly} + ${project.build.directory}/wildfly-preview-current-hv-patch.zip + .. @@ -100,14 +102,16 @@ ${wildfly-main.patch-file} zip - wildfly-${version.wildfly}-patch + wildfly-preview-${version.wildfly}-patch + @@ -135,6 +139,7 @@ + @@ -167,7 +173,7 @@ org.wildfly - wildfly-dist + wildfly-preview-dist ${version.wildfly} tar.gz false @@ -175,13 +181,14 @@ org.wildfly - wildfly-dist + wildfly-preview-dist ${version.wildfly} tar.gz false ${project.build.directory}/wildfly-patched + @@ -216,7 +224,7 @@ jakarta.validation-api ${version.jakarta.validation-api} false - ${wildfly-main.patched.target-dir}/modules/system/layers/base/javax/validation/api/main + ${wildfly-main.patched.target-dir}/modules/system/layers/base/jakarta/validation/api/main jakarta.validation-api-${version.jakarta.validation-api}.jar @@ -237,13 +245,13 @@ hibernate-validator-cdi-${project.version}.jar + jakarta.validation-api-${version.jakarta.validation-api}.jar @@ -262,6 +270,7 @@ ${wildfly-secondary.patched.target-dir}/modules/system/layers/base/org/hibernate/validator/cdi/main hibernate-validator-cdi-${project.version}.jar + --> @@ -271,6 +280,13 @@ org.jboss.as patch-gen-maven-plugin + + + org.jboss.modules + jboss-modules + 1.9.0.Final + + create-wildfly-current-patch-file @@ -285,6 +301,7 @@ ${wildfly-main.patch-file} + diff --git a/modules/src/main/modules/wildfly-current-patch.xml b/modules/src/main/modules/wildfly-current-patch.xml index 5b759320a2..069c3fb3c1 100644 --- a/modules/src/main/modules/wildfly-current-patch.xml +++ b/modules/src/main/modules/wildfly-current-patch.xml @@ -13,7 +13,7 @@ This patch upgrades Hibernate Validator to ${project.version} within a WildFly ${version.wildfly} installation - + diff --git a/modules/src/main/modules/wildfly-secondary-patch.xml b/modules/src/main/modules/wildfly-secondary-patch.xml index 5700566477..d481307b6a 100644 --- a/modules/src/main/modules/wildfly-secondary-patch.xml +++ b/modules/src/main/modules/wildfly-secondary-patch.xml @@ -13,7 +13,7 @@ This patch upgrades Hibernate Validator to ${project.version} within a WildFly ${version.wildfly.secondary} installation - + diff --git a/modules/src/script/setupModules.groovy b/modules/src/script/setupModules.groovy index dbc2d2ea48..6fe317aa7e 100644 --- a/modules/src/script/setupModules.groovy +++ b/modules/src/script/setupModules.groovy @@ -22,14 +22,14 @@ def removeDependency(File file, String dependencyToRemove) { } // Jakarta Bean Validation API -bvModuleXml = new File( wildflyPatchedTargetDir, 'modules/system/layers/base/javax/validation/api/main/module.xml' ) +bvModuleXml = new File( wildflyPatchedTargetDir, 'modules/system/layers/base/jakarta/validation/api/main/module.xml' ) def bvArtifactName = 'jakarta.validation-api-' + project.properties['version.jakarta.validation-api'] + '.jar'; println "[INFO] Using Jakarta Bean Validation version " + bvArtifactName; processFileInplace( bvModuleXml ) { text -> text.replaceAll( /2.2.1.Final - 19.0.0.Final + 22.0.0.Final - 18.0.1.Final + ${version.wildfly} @@ -237,8 +237,8 @@ 2.21.0 ${version.surefire.plugin} 1.2.1.Final - 5.0.0.Final - 2.0.1.Final + 14.0.0.Final + 2.1.0.Final 5.0.3 @@ -337,9 +337,10 @@ ${project.groupId} hibernate-validator-modules ${project.version} - wildfly-${version.wildfly}-patch + wildfly-preview-${version.wildfly}-patch zip + jakarta.validation jakarta.validation-api diff --git a/tck-runner/pom.xml b/tck-runner/pom.xml index be25551e5d..ea08b1c8b5 100644 --- a/tck-runner/pom.xml +++ b/tck-runner/pom.xml @@ -22,7 +22,7 @@ ${project.build.directory}/dependency/beanvalidation-tck-tests-suite.xml - ${project.build.directory}/wildfly-${version.wildfly.tck} + ${project.build.directory}/wildfly-preview-${version.wildfly.tck} org.hibernate.validator.HibernateValidator @@ -255,7 +255,7 @@ ${project.groupId} hibernate-validator-modules ${project.version} - wildfly-${version.wildfly.tck}-patch + wildfly-preview-${version.wildfly.tck}-patch zip @@ -274,7 +274,7 @@ org.wildfly - wildfly-dist + wildfly-preview-dist ${version.wildfly.tck} tar.gz false @@ -295,7 +295,7 @@ ${project.groupId} hibernate-validator-modules ${project.version} - wildfly-${version.wildfly.tck}-patch + wildfly-preview-${version.wildfly.tck}-patch zip ${project.build.directory} @@ -318,7 +318,7 @@ true false - patch apply ${project.build.directory}/hibernate-validator-modules-${project.version}-wildfly-${version.wildfly.tck}-patch.zip + patch apply ${project.build.directory}/hibernate-validator-modules-${project.version}-wildfly-preview-${version.wildfly.tck}-patch.zip diff --git a/tck-runner/src/script/updateStandaloneXml.groovy b/tck-runner/src/script/updateStandaloneXml.groovy index 258f1527f0..89e9a00c79 100644 --- a/tck-runner/src/script/updateStandaloneXml.groovy +++ b/tck-runner/src/script/updateStandaloneXml.groovy @@ -18,7 +18,7 @@ standaloneXml = new File( getPropertyValue('wildfly.target-dir'), 'standalone/co println "[INFO] Add javafx.api as global module" processFileInplace( standaloneXml ) { text -> - text.replaceAll( //, '\n \n \n ' ) + text.replaceAll( //, '\n \n \n ' ) } println "[INFO] ------------------------------------------------------------------------"; diff --git a/tck-runner/src/test/modules/jdk11/javafx/api/main/module.xml b/tck-runner/src/test/modules/jdk11/javafx/api/main/module.xml index 91344118d8..1e52da5a2f 100644 --- a/tck-runner/src/test/modules/jdk11/javafx/api/main/module.xml +++ b/tck-runner/src/test/modules/jdk11/javafx/api/main/module.xml @@ -5,7 +5,7 @@ ~ License: Apache License, Version 2.0 ~ See the license.txt file in the root directory or . --> - +