Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocked users should not be able to sell their OBJKTs #963

Open
jagracar opened this issue Jun 29, 2021 · 3 comments
Open

Blocked users should not be able to sell their OBJKTs #963

jagracar opened this issue Jun 29, 2021 · 3 comments

Comments

@jagracar
Copy link

In my opinion, users in the H=N block list should not be able to sell their (created or collected) OBJKTs in the H=N site.

If i'm not wrong, there seems to be no filter on the collectors tab for swaps coming from blocked users. That means that they could sell their OBJKTs to other users without much troubles.

https://github.com/hicetnunc2000/hicetnunc/blob/main/src/pages/objkt-display/tabs/collectors.js#L42
https://github.com/hicetnunc2000/hicetnunc/blob/main/src/components/owner-swaps/index.js

This feature will complicate a bit the last exploit found in H=N. As soon as the user is identified and added to the black list, he will not be able to sell the editions that he got with the swap trick.

@kylegrover
Copy link
Collaborator

I'm unsure about this. This basically amounts to burning all works bought by banned accounts, but wouldn't actually reduce from total supply. I just want to be sure this wouldn't negatively impact the genuine artists whose works were purchased by bad actors.

@jagracar
Copy link
Author

I get your point... The thing is that if bad actors are not allowed to sell their collected OBJKTs, they will be discouraged to act again. Otherwise, they will keep going, since they will get benefits of their acts.

But I understand that those editions will not be sold, and the creator will miss the royalties.

Difficult decision. If one manages to discourage totally bad actors, the second problem will not happen anymore. But one never knows...

@jagracar
Copy link
Author

Maybe this is a good case for a hDAO voting ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants