feat: initial scaffolding for directive validation and git-based directives #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krancour
changed the title
krancour
force-pushed
the
krancour/alt-promotion-directives
branch
from
b6be5b7 to
5573655
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## promotion-directives #4 +/- ##
=======================================================
Coverage ? 48.51%
=======================================================
Files ? 255
Lines ? 17897
Branches ? 0
=======================================================
Hits ? 8683
Misses ? 8778
Partials ? 436 ☔ View full report in Codecov by Sentry. |
krancour
force-pushed
the
krancour/alt-promotion-directives
branch
from
5573655 to
534e188
Compare
krancour
commented
Aug 28, 2024
Comment on lines
+168
to
+187
| .PHONY: codegen-docs | ||
| codegen-docs: | ||
| npm install -g @bitnami/readme-generator-for-helm | ||
| bash hack/helm-docs/helm-docs.sh | ||
|
|
There was a problem hiding this comment.
No changes here. I just re-ordered the targets so they are defined in the same order they are executed when using make codegen. I thought it made it slightly easier to follow.
krancour
commented
Aug 28, 2024
Comment on lines
+22
to
+23
| sed -i.bak 's/\*bool/bool/g' ${out_file} | ||
| sed -i.bak 's/\*string/string/g' ${out_file} |
There was a problem hiding this comment.
The tool uses pointers for anything optional, which is annoying AF for strings and bools (maybe ints, too). There wasn't a flag to change that behavior, so I resorted to this.
krancour
commented
Aug 28, 2024
| @@ -6,7 +6,7 @@ import ( | |||
| "fmt" | |||
| ) | |||
|
|
|||
| func init() { | |||
| func init() { | |||
krancour
commented
Aug 28, 2024
| @@ -92,4 +92,3 @@ func configToStruct[T any](c Config) (T, error) { | |||
|
|
|||
| return result, nil | |||
| } | |||
|
|
|||
krancour
commented
Aug 28, 2024
| @@ -17,7 +17,6 @@ func BuiltinsRegistry() DirectiveRegistry { | |||
| // register and retrieve directives by name. | |||
| type DirectiveRegistry map[string]Directive | |||
|
|
|||
|
|
|||
hiddeco
force-pushed
the
promotion-directives
branch
from
e3c3941 to
367ad99
Compare
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
krancour
force-pushed
the
krancour/alt-promotion-directives
branch
from
534e188 to
7a314f8
Compare
…privileges Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
…f a dir Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
hiddeco
reviewed
Aug 30, 2024
| @@ -47,11 +47,11 @@ func NewEngine( | |||
| // Execute runs the provided list of directives in sequence. | |||
| func (e *Engine) Execute(ctx context.Context, steps []Step) (Result, error) { | |||
| // TODO(hidde): allow the workDir to be restored from a previous execution. | |||
| workDir, err := os.CreateTemp("", "run-") | |||
| workDir, err := os.MkdirTemp("", "run-") | |||
hiddeco
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.