added unit-tests for the "mac"-package #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boris-de
force-pushed
the
mac_unittests
branch
from
489e59c
to
665cbf0
Compare
This was referenced Jan 11, 2015
Merged
hierynomus
added a commit
that referenced
this pull request
Jan 12, 2015
added unit-tests for the "mac"-package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As wished in #156 here are some unittests, for the HMACs at least. I'll try to look into creating a test for the KeyExchanger when I've got time.
While I was at it I created tests for all classes in the "mac"-package. This way I also found a bug in BaseMac which will be fixed with another PR (this is why some of the tests are currently disabled in HMACSHA196Test and HMACMD596Test).
The tests all create a hmac of "Hello World" with a random key of the expected size. I cross-checked the results with two different online services for hmacs.