-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix length field for SSH_FXP_WRITE packets. #181
Conversation
Wondering whether the code @shikhar wrote is actually correct here. According to the spec there is no length field, i.e.
(source: http://www.openssh.com/txt/draft-ietf-secsh-filexfer-02.txt) |
I think the |
That field is actually handled in the SFTPEngine#transmit method. That ensures that it transmits the |
I will run some interoperability tests with OpenSSH if omitting the field is fine then. |
I have errors when omitting the length in the before the raw bytes in the
|
I'll merge this PR, as it indeed fixes the bug... Still wondering though why we need to length field in the SSH_FXP_WRITE packet. Opened #187 for this. |
Fix length field for SSH_FXP_WRITE packets.
Proposed fix for #180.