SCP : limit the used bandwidth

[lguerin]

Hello,

I have a strong requirement to limit usage of bandwidth at application level when I upload files to a remote server.
According to the scp man page, I have added a '-l XXX' arg to the SCPEngine class.
Then, to keep the fluent aspect of your API, this new arg can (optionally) be set as below:

// Limit upload transfert at 128Ko/s
ssh.newSCPFileTransfer().bandwidthLimit(1024).upload(new FileSystemFile(src), "/tmp/");

A test case is provided into SCPFileTransferTest for upload and download features.
Thanks.

[hierynomus]

Hi! Thanks for the PR. Unfortunately, Travis claims that one test is failing. Can you have a look and fix it?

[lguerin]

Hi,
I don't really know why the first build has failed, whereas the tests was ok on my local machine and with my travis instance: https://travis-ci.org/lguerin/sshj/builds/75394840
I just have change the logging level for tests in gradle file to get more informations about the exception cause if the error occurs again.

[hierynomus]

typo in comment (transfert). Also is it kilobit, or kilobyte? The difference is a factor 8.

[lguerin]

Sorry for the typo. It's kilobit/s, according to the scp man page.

[hierynomus]

Why the extra 'v' here? It is not used currently. The LIMIT seems to use it, but as it is an enum it is always the empty string.

[lguerin]

Some scp options needs a key/value structure. The value is initialized with an empty string but can be set through the helper class SCPArguments. This the way I have used to set the value of the LIMIT arg.

[hierynomus]

Ahh but this is even more evil, as this is an enum, setting the value for 1 process means that you're setting it (inadvertently) for all processes. Because there is only 1 instance of the same enum key in a JVM. So please refactor that and remove the setValue(..)

[hierynomus]

Thanks! Looks good now I think. Will do some testing on it, and then merge it in next week.

[lguerin]

Nice, thank you.

[hierynomus]

Merged, thx!