-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for SHA-256/512 with ssh-rsa keys #588
Comments
Definitely a good idea, I'll have a look. Would you prefer a release before this? |
If it wouldn't require too much work on your part, I would. I'm currently working on Android Keystore-backed SSH keys for Password Store based on my PRs that have already been merged, whereas SHA-256/512 support is something that Password Store could use without any changes to our code. |
@FabianHenneke I added these to #589. |
Thanks for the quick implementation, that looks pretty good! |
It would be great if support for the modern
rsa-sha2-256
andrsa-sha2-512
signature types could be added. Currently, RSA keys are limited to SHA1.I would work on this myself, but I do not know how to implement this cleanly. The current design seems to be based on the assumption that there is a 1-to-1 mapping between key types and signature types. If you can provide me with a rough sketch of how this could be fit into the code, I would execute the plan when I have time.
The text was updated successfully, but these errors were encountered: