Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order OrderLines are incorrectly RefundLineType #13

Open
dpash opened this issue Sep 28, 2023 · 3 comments
Open

Order OrderLines are incorrectly RefundLineType #13

dpash opened this issue Sep 28, 2023 · 3 comments

Comments

@dpash
Copy link

dpash commented Sep 28, 2023

The JSON uses RefundLineType rather than OrderLineType for the OrderLlines returned from the "getAllOrders", which means that none of the data in the order lines are available.

I've tried to rebuild the project, but I'm getting OpenAPI Generator errors that I don't know how to resolve.

I think the following in the replacements.json should solve the issue.

      "orders": {
          "schemas": {
              "Order": {
                  "properties": {
                      "orderLines": {
                          "$refs": "#\/components\/schemas\/OrderLinesType"
                      }
                  }
              }
          }
      }
@arons-3c
Copy link

following!

@arons-3c
Copy link

@dpash can you provide an example on how to make this work? Thanks

dpash added a commit to dpash/walmart-api-php that referenced this issue Feb 19, 2024
The `orderLines` type in the schema was incorrectly set to be `RefundLinesType`
which meant that many of the values were not exposed to the user.

Fixes highsidelabs#13, fixes highsidelabs#17, fixes highsidelabs#19
dpash added a commit to dpash/walmart-api-php that referenced this issue Feb 19, 2024
This is the result of customising the schema after the previous commit

Fixes highsidelabs#13, fixes highsidelabs#17, fixes highsidelabs#19
dpash added a commit to dpash/walmart-api-php that referenced this issue Feb 19, 2024
This is the result of generating the API from the schema

Fixes highsidelabs#13, fixes highsidelabs#17, fixes highsidelabs#19
@dpash
Copy link
Author

dpash commented Feb 19, 2024

https://github.com/dpash/walmart-api-php/tree/fix-getallorders should resolve this issue.

It currently depends on #21 being merged. I can cherry-pick the commits into a new branch without the build fixes if you'd prefer not to include those. It's also three commits. Let me know if you'd prefer me to squash them into a single commit.

dpash added a commit to dpash/walmart-api-php that referenced this issue Feb 27, 2024
Turns out I missed one incorrect type, so this should hopefully fix that too

Fixes highsidelabs#13, fixes highsidelabs#17, fixes highsidelabs#19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants