-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
customize-schemas.php is not idempotent #22
Comments
Hey @dpash -- thanks for the well-thought-out issue. Totally agree that this is a problem. I've reworked the schema download/customize/generate pipeline in the (still WIP) Appreciate the offer of a PR -- for the sake of simplicity, I'd like to keep the pipeline for this repo as similar as possible to the pipeline in that |
Hey, have you done any work on migrating this library to use saloon, or should I look into doing so? Seems Walmart have considerably updated their JSON schema since this library was last built and it no longer builds. Seems pointless trying to fix up the old build system if you're planning on migrating away. |
I haven't had a chance to get started on migrating to Saloon, no, although I would like to do so eventually. If you're feeling inspired and want to get started on the revamp, please feel free! Happy to review PRs. Keeping the structure as similar as possible to |
Running
customize-schemas.php
multiple times results in further modifications of the schemas.There's three issues:
'x-expose-headers'
is added where as previously it's not included. This seems to be a bug due to it being stripped out when first run.I have fixes for the first two and I'll create a PR for these. I still need to figure out how to resolve the addition issue.
An alternative approach is to download the original schemas to a different directory and then have the
customize-schemas.php
write out the schemas to new files.The text was updated successfully, but these errors were encountered: